Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pcsx2: multiple improvements #104881

Closed
wants to merge 2 commits into from
Closed

[20.09] pcsx2: multiple improvements #104881

wants to merge 2 commits into from

Conversation

samuelgrf
Copy link
Member

Motivation for this change

Fixes #104850

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from hrdinka November 25, 2020 10:10
@hrdinka
Copy link
Contributor

hrdinka commented Nov 25, 2020

Thanks for the backport! I guess you have omitted the latest update to PCSX2 due the dependency on fmt?

@samuelgrf
Copy link
Member Author

samuelgrf commented Nov 25, 2020 •
edited

That's part of the reason, but I mainly wanted to keep things as stable as possible; the last update was merged only a week ago.

@hrdinka hrdinka mentioned this pull request Dec 12, 2020
Closed
@samuelgrf
Copy link
Member Author

Closing due to issues with software renderer

@samuelgrf samuelgrf closed this Mar 29, 2021
@samuelgrf samuelgrf deleted the backport/pcsx2_gtk3-x86_64 branch March 5, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrdinka hrdinka Awaiting requested review from hrdinka

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelgrf @hrdinka