Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.coq-ext-lib: 0.11.2 → 0.11.3 #104868

Merged
merged 2 commits into from Dec 1, 2020
Merged

coqPackages.coq-ext-lib: 0.11.2 → 0.11.3 #104868

merged 2 commits into from Dec 1, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 25, 2020

Motivation for this change

Refactoring motivated by #73075, so as to ease overriding.
cc @Ptival

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ptival
Copy link
Contributor

Ptival commented Nov 25, 2020

Nice, thanks!

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104868 run on x86_64-linux 1

3 packages built:
  • coqPackages.QuickChick
  • coqPackages.coq-ext-lib
  • coqPackages.simple-io

@vbgl vbgl merged commit 4569be3 into NixOS:master Dec 1, 2020
@vbgl vbgl deleted the coq-coq-ext-lib-0.11.3 branch December 1, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: coq 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Ptival @SuperSandro2000