Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.easyScreenCast: init at unstable-2020-11-25 #104888

Merged
merged 1 commit into from Dec 5, 2020
Merged

gnomeExtensions.easyScreenCast: init at unstable-2020-11-25 #104888

merged 1 commit into from Dec 5, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 25, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar force-pushed the pkg/gnomeExtensions/easyScreenCast branch from 9d338c6 to 7c77fd3 Compare November 25, 2020 12:18
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/need-help-packaging-a-gnome-shell-extension/10192/1

@doronbehar doronbehar force-pushed the pkg/gnomeExtensions/easyScreenCast branch from 7c77fd3 to d6a1965 Compare November 25, 2020 12:34
@doronbehar doronbehar force-pushed the pkg/gnomeExtensions/easyScreenCast branch 2 times, most recently from 4b90215 to a663c94 Compare November 25, 2020 12:55
@doronbehar doronbehar marked this pull request as ready for review November 25, 2020 12:55
@doronbehar doronbehar mentioned this pull request Nov 25, 2020
Merged
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104888 run on x86_64-linux 1

1 package built:
  • gnomeExtensions.easyScreenCast

@doronbehar
Copy link
Contributor Author

I will wait a while before merging this, to see it works.

@doronbehar
Copy link
Contributor Author

This is working pretty good - I'm using it for a while now. Upstream isn't responsive regarding the PR there that points to the branch in use here. I'm subscribed to that PR thread, and I'll update the expression if upstream will respond. I'm merging this in the meantime.

@doronbehar doronbehar force-pushed the pkg/gnomeExtensions/easyScreenCast branch from a663c94 to db6178b Compare December 5, 2020 09:57
@doronbehar doronbehar merged commit 7e96d9e into NixOS:master Dec 5, 2020
@doronbehar doronbehar deleted the pkg/gnomeExtensions/easyScreenCast branch December 5, 2020 10:36
@doronbehar doronbehar changed the title gnomeExtensions.easyScreenCast: init at 1.1.0 gnomeExtensions.easyScreenCast: init at unstable-2020-11-25 Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @nixos-discourse @SuperSandro2000 @jtojnar