Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viber: 7.0.0.1035 -> 13.3.1.22 #104880

Merged
merged 1 commit into from Nov 25, 2020
Merged

Conversation

ivankovnatsky
Copy link
Contributor

@ivankovnatsky ivankovnatsky commented Nov 25, 2020

Motivation for this change
trying https://download.cdn.viber.com/cdn/desktop/Linux/viber.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 95.0M  100 95.0M    0     0  10.7M      0  0:00:08  0:00:08 --:--:-- 11.1M
hash mismatch in fixed-output derivation '/nix/store/gb3nafqslnmmrz3853wxll4k4vdjj68b-viber.deb':
  wanted: sha256:06mp2wvqx4y6rd5gs2mh442qcykjrrvwnkhlpx0lara331i2p0lj
  got:    sha256:0rs26x0lycavybn6k1hbb5kzms0zzcmxlrmi4g8k7vyafj6s8dqh
cannot build derivation '/nix/store/5hlb0lc3bqg9zq2c5pwff4fyih67f8ip-viber-7.0.0.1035.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j6l7p7x7azmk1ayf7j102jgv51iwl9zi-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3rdwp8765ck93vwblwqcql73a1lbpaa8-nixos-system-mac-21.03pre253060.a322b32e9d7.drv': 1 dependencies couldn't be built
error: build of '/nix/store/3rdwp8765ck93vwblwqcql73a1lbpaa8-nixos-system-mac-21.03pre253060.a322b32e9d7.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ivankovnatsky
Copy link
Contributor Author

nixpkgs-review pr 104880
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs nixos-unstable:refs/nixpkgs-review/0 pull/104880/head:refs/nixpkgs-review/1
From https://github.com/NixOS/nixpkgs
 * [new branch]              nixos-unstable        -> refs/nixpkgs-review/0
 * [new ref]                 refs/pull/104880/head -> refs/nixpkgs-review/1
$ git worktree add /home/sevenfourk/.cache/nixpkgs-review/pr-104880/nixpkgs 2247d824fe07f16325596acc7faa286502faffd1
Preparing worktree (detached HEAD 2247d824fe0)
Updating files: 100% (23269/23269), done.
HEAD is now at 2247d824fe0 Merge pull request #104479 from Mic92/freeoffice
$ nix-env -f /home/sevenfourk/.cache/nixpkgs-review/pr-104880/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 9173b3e67ee1ed0516456db43af797e7c3f8ce87
Updating 2247d824fe0..9173b3e67ee
Fast-forward
 pkgs/applications/networking/instant-messengers/viber/default.nix | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
$ nix-env -f /home/sevenfourk/.cache/nixpkgs-review/pr-104880/nixpkgs -qaP --xml --out-path --show-trace --meta
1 package updated:
viber

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/sevenfourk/.cache/nixpkgs-review/pr-104880/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/104880
1 package built:
viber

[0.0 MiB DL]
$ nix-shell /home/sevenfourk/.cache/nixpkgs-review/pr-104880/shell.nix
these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
  /nix/store/fp7y3g7nwsy3hp0xlgmbh2rigz1ksjss-bash-interactive-4.4-p23-dev
copying path '/nix/store/fp7y3g7nwsy3hp0xlgmbh2rigz1ksjss-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

[nix-shell:~/.cache/nixpkgs-review/pr-104880]$

@ivankovnatsky ivankovnatsky marked this pull request as ready for review November 25, 2020 09:52
@ivankovnatsky ivankovnatsky marked this pull request as draft November 25, 2020 09:55
@ivankovnatsky
Copy link
Contributor Author

running in pr nix-shell causes this:

Got keys from plugin meta data ("xcb")
QFactoryLoader::QFactoryLoader() checking directory path "/nix/store/vfynhq88b11b1lgz8imchykvcv4cli0q-viber-7.0.0.1035/opt/viber/platforms" ...
Cannot load library /nix/store/vfynhq88b11b1lgz8imchykvcv4cli0q-viber-7.0.0.1035/opt/viber/plugins/platforms/libqxcb.so: (libxkbcommon-x11.so.0: cannot open sh
ared object file: No such file or directory)
QLibraryPrivate::loadPlugin failed on "/nix/store/vfynhq88b11b1lgz8imchykvcv4cli0q-viber-7.0.0.1035/opt/viber/plugins/platforms/libqxcb.so" : "Cannot load libr
ary /nix/store/vfynhq88b11b1lgz8imchykvcv4cli0q-viber-7.0.0.1035/opt/viber/plugins/platforms/libqxcb.so: (libxkbcommon-x11.so.0: cannot open shared object file
: No such file or directory)"
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, webg
l, xcb.

Aborted (core dumped)

@ivankovnatsky ivankovnatsky changed the title viber: fixed sha256 mismatch viber: 7.0.0.1035 -> 13.3.1.22 Nov 25, 2020
@ivankovnatsky
Copy link
Contributor Author

ivankovnatsky commented Nov 25, 2020

now it runs fine:

[nix-shell:~/.cache/nixpkgs-review/pr-104880-3]$ viber
qml: CALL_WEB_VIEW_DEBUG: callWebEngineLoader active: false
qrc:/QML/DebugMenu.qml:248: TypeError: Cannot call method 'isIdentityChangeNotificationsEnabled' of undefined
...
qrc:/QML/Feed/FeedView.qml:108:5: QML ListViewEx: Binding loop detected for property "bottomMargin"
^C
[nix-shell:~/.cache/nixpkgs-review/pr-104880-3]$

@ivankovnatsky ivankovnatsky marked this pull request as ready for review November 25, 2020 11:26
@SuperSandro2000 SuperSandro2000 changed the base branch from nixos-unstable to master November 25, 2020 11:58
@SuperSandro2000
Copy link
Member

I changed the target branch to master.

@ivankovnatsky
Copy link
Contributor Author

@SuperSandro2000 thanks, getting used to it.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104880 run on x86_64-linux 1

1 package built:
  • viber

@SuperSandro2000 SuperSandro2000 merged commit 71082c2 into NixOS:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants