Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos auto-upgrade: remove flag when flake #104870

Merged
merged 1 commit into from Nov 25, 2020
Merged

nixos auto-upgrade: remove flag when flake #104870

merged 1 commit into from Nov 25, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 25, 2020

The --no-build-output flag that is added by default is only valid
for the old cli, which is not used when flakes are used.

Follow-up to c9daa81.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Kloenk

@FRidh FRidh mentioned this pull request Nov 25, 2020
Merged
10 tasks
@FRidh
nixos auto-upgrade: remove flag when flake
5790bb0 
The `--no-build-output` flag that is added by default is only valid
for the old cli, which is not used when flakes are used.

Follow-up to c9daa81.
Kloenk
Kloenk approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@Kloenk Kloenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etu etu merged commit 54745a4 into NixOS:master Nov 25, 2020
@FRidh FRidh mentioned this pull request Nov 29, 2020
Closed
@FRidh FRidh deleted the flake branch November 29, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu left review comments

@Kloenk Kloenk Kloenk approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @etu @Kloenk