Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.jupyterlab-git: 0.22.3 -> 0.23.1 #104893

Merged
merged 2 commits into from Nov 25, 2020
Merged

python37Packages.jupyterlab-git: 0.22.3 -> 0.23.1 #104893

merged 2 commits into from Nov 25, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

Closes #104873

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 force-pushed the auto-update/python3.7-jupyterlab_git branch from 90bcd8f to 80c0685 Compare November 25, 2020 13:01
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104893 run on x86_64-linux 1

2 package built:
  • python37Packages.jupyterlab-git
  • python38Packages.jupyterlab-git

@SuperSandro2000 SuperSandro2000 force-pushed the auto-update/python3.7-jupyterlab_git branch from 80c0685 to b93aba5 Compare November 25, 2020 13:33
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104893 run on x86_64-linux 1

2 packages built:
  • python37Packages.jupyterlab-git
  • python38Packages.jupyterlab-git

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104893 run on x86_64-darwin 1

2 packages built:
  • python37Packages.jupyterlab-git
  • python38Packages.jupyterlab-git

jonringer
jonringer approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104893 1

2 packages built:
  • python37Packages.jupyterlab-git
  • python38Packages.jupyterlab-git

@jonringer jonringer merged commit 3c72ba6 into NixOS:master Nov 25, 2020
@SuperSandro2000 SuperSandro2000 deleted the auto-update/python3.7-jupyterlab_git branch November 26, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @jonringer @r-ryantm