Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpc-qt: Fix compilation failure due to mpv changes #104892

Merged
merged 1 commit into from Nov 25, 2020
Merged

mpc-qt: Fix compilation failure due to mpv changes #104892

merged 1 commit into from Nov 25, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#104865 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from romildo November 25, 2020 12:53
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104892 run on x86_64-linux 1

1 package built:
  • mpc-qt

@AndersonTorres AndersonTorres merged commit db63be9 into NixOS:master Nov 25, 2020
AndersonTorres
AndersonTorres reviewed Nov 25, 2020
View reviewed changes
pkgs/applications/video/mpc-qt/default.nix
@@ -11,7 +11,14 @@ mkDerivation rec {
sha256 = "1cis8dl9pm91mpnp696zvwsfp96gkwr8jgs45anbwd7ldw78w4x5";
};

nativeBuildInputs = [ pkgconfig qmake qttools ];
patches = [
(fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have seen it, wouldn't be better using fetchpatch?

@SuperSandro2000 SuperSandro2000 deleted the mpc-qt-fix branch November 25, 2020 16:43
@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 25, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres left review comments

@prusnak prusnak prusnak approved these changes

@romildo romildo Awaiting requested review from romildo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @prusnak @AndersonTorres