Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etebase-server: init at 0.7.0 #104003

Merged
merged 4 commits into from Feb 5, 2021
Merged

Conversation

felschr
Copy link
Member

@felschr felschr commented Nov 16, 2020

Motivation for this change

Add Etebase server (EteSync 2.0) package and NixOS module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@felschr
Copy link
Member Author

felschr commented Nov 28, 2020

So far I got the package itself working and I made some progress on creating a NixOS module.
The module doesn't work right now but I'm quite close to get it into a working state.

Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like really awesome :)

nixos/modules/services/misc/etebase-server.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/etebase-server.nix Outdated Show resolved Hide resolved
pkgs/servers/etebase/default.nix Outdated Show resolved Hide resolved
@felschr
Copy link
Member Author

felschr commented Dec 3, 2020

Alright, I got the service to start up now. But I have yet to test whether it's actually working properly.
I'll also have to refactor a few bits & extend the configuration options. Hopefully I can finish this up on the weekend.

@felschr felschr marked this pull request as ready for review January 16, 2021 16:15
@felschr
Copy link
Member Author

felschr commented Jan 16, 2021

And it's working 🥳

@felschr felschr changed the title etebase-server: init at 0.5.3 etebase-server: init at 0.7.0 Jan 16, 2021
pkgs/servers/etebase/default.nix Outdated Show resolved Hide resolved
pkgs/servers/etebase/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104003 run on x86_64-darwin 1

4 packages failed to build and are new build failures:
  • etebase-server: log was empty
  • python37Packages.etebase-server: log was empty
  • (python38Packages.etebase-server: log was empty
  • ,python39Packages.etebase-server): log was empty
3 packages built:
  • python37Packages.drf-nested-routers
  • python38Packages.drf-nested-routers
  • python39Packages.drf-nested-routers

@SuperSandro2000
Copy link
Member

hash mismatch in fixed-output derivation '/nix/store/0swbp1xb7rcnanrp3wfxjr1xbpc6n581-source.drv':                                                                                            specified: sha256-cS1VtAC7sQ2l9RTV7N6iQjpMZf9uKMyzoQMKnuI8SuQ=                                                                                                                                 got:    sha256-CFCzGRDTjv38dZgDJu9GmVfgP7CAyM94L0shwJFFnj8=

@felschr
Copy link
Member Author

felschr commented Jan 17, 2021

nixpkgs-review succeeds on x86_64-linux. I'm not sure how to investigate the issue.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104003 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
5 packages built:
  • etebase-server
  • python37Packages.drf-nested-routers
  • python37Packages.etebase-server (python38Packages.etebase-server ,python39Packages.etebase-server)
  • python38Packages.drf-nested-routers
  • python39Packages.drf-nested-routers

@SuperSandro2000
Copy link
Member

nixpkgs-review succeeds on x86_64-linux. I'm not sure how to investigate the issue.

I am not sure whats happening here either. I would suggest to just mark it broken on darwin and then we can merge.

nixos/modules/services/misc/etebase-server.nix Outdated Show resolved Hide resolved
pkgs/servers/etebase/default.nix Outdated Show resolved Hide resolved
pkgs/servers/etebase/wrapped.nix Outdated Show resolved Hide resolved
@felschr felschr force-pushed the feat/etebase-server branch 2 times, most recently from eed849c to 442c523 Compare January 19, 2021 16:22
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package LGTM

@felschr
Copy link
Member Author

felschr commented Jan 25, 2021

@jonringer can we get this merged?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104003 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • etebase-server
  • python37Packages.etebase-server
  • python38Packages.etebase-server
  • python39Packages.etebase-server
3 packages built:
  • python37Packages.drf-nested-routers
  • python38Packages.drf-nested-routers
  • python39Packages.drf-nested-routers

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104003 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
4 packages built:
  • etebase-server (python37Packages.etebase-server ,python38Packages.etebase-server ,python39Packages.etebase-server)
  • python37Packages.drf-nested-routers
  • python38Packages.drf-nested-routers
  • python39Packages.drf-nested-routers

1 similar comment
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104003 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
4 packages built:
  • etebase-server (python37Packages.etebase-server ,python38Packages.etebase-server ,python39Packages.etebase-server)
  • python37Packages.drf-nested-routers
  • python38Packages.drf-nested-routers
  • python39Packages.drf-nested-routers

@felschr felschr requested a review from mweinelt February 4, 2021 09:10
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/341

@7c6f434c 7c6f434c merged commit e248519 into NixOS:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants