Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirrors: fix lua mirrors #104005

Merged
merged 1 commit into from Dec 8, 2020
Merged

mirrors: fix lua mirrors #104005

merged 1 commit into from Dec 8, 2020

Conversation

teto
Copy link
Member

@teto teto commented Nov 16, 2020

Seems like urls in mirrors in a string format must end up with a / otherwise download fails (they got changed from nix url type into string is in march). We had one working mirror but now that it is unavailable I could not install any lua package not in the cache.

A similar issue may happen with "http://tarballs.nixos.org" ?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Seems like urls in mirrors must end up with a / otherwise download fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant