Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mullvad-vpn: add iproute2 #104015

Merged
merged 1 commit into from Nov 24, 2020
Merged

mullvad-vpn: add iproute2 #104015

merged 1 commit into from Nov 24, 2020

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Nov 17, 2020

Motivation for this change

Since 2020.5 (released in july) mullvad-daemon will try to write to /etc/iproute2/rt_tables
This change enables the copying of those config files over to /etc

Resolves #91923

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

It would be nice if there was a test to assert this change fixes the issue. Also would help deter future regressions.

@jonringer
Copy link
Contributor

But, looking at the issue, this is still an improvement, so the test can be a separate PR

@jonringer jonringer merged commit 4db2392 into NixOS:master Nov 24, 2020
@lheckemann
Copy link
Member

Backported to 20.09: 7d71d3d

@Artturin Artturin deleted the fix-mullvad branch August 3, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mullvad-vpn 2020.5 broken
3 participants