Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine: only use strictDeps when mingwSupport is enabled #104001

Merged
merged 1 commit into from Nov 17, 2020
Merged

wine: only use strictDeps when mingwSupport is enabled #104001

merged 1 commit into from Nov 17, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Nov 16, 2020 •
edited

Motivation for this change

9f5cba0 broke regular wineStaging

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from avnik and bendlas November 16, 2020 22:29
kira-bruneau
kira-bruneau approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@kira-bruneau kira-bruneau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Atemu! Sorry I should have tested wineStaging too.

@7c6f434c 7c6f434c merged commit 0ccc3ec into NixOS:master Nov 17, 2020
@Atemu Atemu deleted the wineStaging-strictDeps-regression branch October 7, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kira-bruneau kira-bruneau kira-bruneau approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@avnik avnik Awaiting requested review from avnik

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atemu @kira-bruneau @7c6f434c