Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upwork: 5.4.7.1 -> 5.4.9.6 #104016

Merged
merged 1 commit into from Dec 29, 2020
Merged

upwork: 5.4.7.1 -> 5.4.9.6 #104016

merged 1 commit into from Dec 29, 2020

Conversation

WolfangAukang
Copy link
Contributor

Motivation for this change

Updating version from 5.4.7.1 to 5.4.9.6. This will avoid the upgrade message that requires restarting the application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/297

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/411

@AndersonTorres
Copy link
Member

Who reviewed this?

@WolfangAukang
Copy link
Contributor Author

WolfangAukang commented Dec 22, 2020 •
edited

@AndersonTorres no one yet. Posted on the wrong discourse thread. It requires review though.

@jonringer
Copy link
Contributor

jonringer commented Dec 29, 2020 •
edited

you rang?

jonringer
jonringer approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/104016

1 package built:
upwork

@jonringer jonringer merged commit 71f9181 into NixOS:master Dec 29, 2020
@WolfangAukang
Copy link
Contributor Author

WolfangAukang commented Dec 29, 2020 •
edited

@jonringer sorry for the lack of context. I put you as approver as you approved this package previously. Thank you!

@WolfangAukang WolfangAukang deleted the wolfangaukang/upwork-5.4.9.6 branch December 29, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WolfangAukang @nixos-discourse @AndersonTorres @jonringer