Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.uvicorn 0.11.5 -> 0.12.2 and fix tests on darwin #104006

Closed
wants to merge 1 commit into from
Closed

pythonPackage.uvicorn 0.11.5 -> 0.12.2 and fix tests on darwin #104006

wants to merge 1 commit into from

Conversation

thanegill
Copy link
Contributor

Motivation for this change

Update uvicorn and fix tests on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Nov 16, 2020
@ofborg ofborg bot requested a review from wd15 November 16, 2020 23:00
@wd15
Copy link
Contributor

wd15 commented Nov 18, 2020 •
edited

Built for Python 3.8, but not Python 3.7. Should it build for Python 3.7 and if not then add isPy37 along with isPy27?

$ nix-build . -A python37Packages.uvicorn
these derivations will be built:                                                                                                                             
  /nix/store/dsqapcd4nzxkasn4pw9psdqrhrlr10yl-python3.7-uvicorn-0.12.2.drv
...
ERROR: Could not find a version that satisfies the requirement typing-extensions; python_version < "3.8" (from uvicorn==0.12.2) (from versions: none)
ERROR: No matching distribution found for typing-extensions; python_version < "3.8" (from uvicorn==0.12.2)
builder for '/nix/store/dsqapcd4nzxkasn4pw9psdqrhrlr10yl-python3.7-uvicorn-0.12.2.drv' failed with exit code 1
error: build of '/nix/store/dsqapcd4nzxkasn4pw9psdqrhrlr10yl-python3.7-uvicorn-0.12.2.drv' failed

@mweinelt mweinelt mentioned this pull request Nov 18, 2020
Merged
10 tasks
@mweinelt
Copy link
Member

mweinelt commented Nov 18, 2020 •
edited

This change breaks the httpx tests, they reproducibly get stuck at:

============================= test session starts ==============================
platform linux -- Python 3.8.6, pytest-5.4.3, py-1.9.0, pluggy-0.13.1
rootdir: /build/source, inifile: setup.cfg
plugins: asyncio-0.14.0, trio-0.6.0, cov-2.10.1
collected 584 items / 4 deselected / 580 selected

tests/test_api.py ..........                                             [  1%]
tests/test_asgi.py ..............                                        [  4%]
tests/test_auth.py ...                                                   [  4%]

specifically during the test_load_ssl_config_verify_env_file the case.

@mweinelt mweinelt mentioned this pull request Jan 6, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

@thanegill can you fix the merge conflict and take a look at the hanging tests?

@mweinelt
Copy link
Member

mweinelt commented Jan 6, 2021

Superseded by #108602 . I've pulled in the darwin test fix.

@mweinelt mweinelt closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@wd15 wd15 Awaiting requested review from wd15

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thanegill @wd15 @mweinelt @SuperSandro2000