Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

woff2: use canonical prefixes #104007

Merged
merged 1 commit into from Nov 19, 2020
Merged

woff2: use canonical prefixes #104007

merged 1 commit into from Nov 19, 2020

Conversation

bhpdt
Copy link

@bhpdt bhpdt commented Nov 16, 2020 •
edited

When building with a native stdenv, which wraps CC, we need to resolve nix store
symlinks when building woff2.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

woff2: use canonical prefixes
c2d85c3 
When building with a native stdenv, which wraps CC, we need to resolve nix store
symlinks when building woff2.
@ofborg ofborg bot requested a review from hrdinka November 16, 2020 23:59
@FRidh FRidh added this to WIP in Staging via automation Nov 18, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Nov 18, 2020
@hrdinka hrdinka merged commit 1567cf8 into NixOS:master Nov 19, 2020
Staging automation moved this from Needs review to Done Nov 19, 2020
@hrdinka
Copy link
Contributor

hrdinka commented Nov 19, 2020

Great change, thanks for the fix! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrdinka hrdinka Awaiting requested review from hrdinka

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhpdt @hrdinka