Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tektoncd-cli: 0.13.1 -> 0.14.0 #103999

Merged
merged 2 commits into from Nov 23, 2020
Merged

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Nov 16, 2020

Motivation for this change

Bump tkn to 0.14.0. Move to new installShellConfiguration format

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac 06kellyjac changed the title Tekton cli 0.14.0 tektoncd-cli: 0.13.1 -> 0.14.0 Nov 16, 2020
@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 103999 1

1 package built:
  • tektoncd-cli

@06kellyjac
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 17, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 17, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103999 run on x86_64-darwin 1

1 package built:
  • tektoncd-cli

@SuperSandro2000 SuperSandro2000 merged commit 0c07eab into NixOS:master Nov 23, 2020
@06kellyjac 06kellyjac deleted the tekton-cli_0.14.0 branch November 23, 2020 15:15
@06kellyjac
Copy link
Member Author

@SuperSandro2000 thanks for all the reviews 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants