Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: disable darwin bootstrapped stdenv test #104013

Merged
merged 1 commit into from Nov 17, 2020
Merged

release: disable darwin bootstrapped stdenv test #104013

merged 1 commit into from Nov 17, 2020

Conversation

thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Nov 17, 2020 •
edited

Motivation for this change

This targets a failing job that will block the channel.

The bootstrap tools are internally consistent, but as expressed in the comment, the generated tools and used tools are different enough that the unpack script doesn't handle them both. We can either disable the test, or try to make unpack handle both. There's still some work to be done in making a new unpack script, and it may require changes to the bootstrap tarball itself. For now I'd prefer to disable this test, and re-enable it when we're ready to merge the new bootstrap tools.

cc @LnL7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 17, 2020
@thefloweringash thefloweringash mentioned this pull request Nov 17, 2020
Merged
10 tasks
@FRidh FRidh added the 1.severity: channel blocker Blocks a channel label Nov 17, 2020
vcunat
vcunat approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, though it's more about what darwin users want.

LnL7
LnL7 approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it's more important to get 11.0 support out. With how much the libSystem approach changed now it's better to clean things up a bit instead of making both cases work.

@LnL7 LnL7 merged commit aec155e into NixOS:master Nov 17, 2020
@thefloweringash thefloweringash deleted the remove-darwin-bootstrap-test branch November 17, 2020 20:49
@thefloweringash thefloweringash mentioned this pull request Jun 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@vcunat vcunat vcunat approved these changes

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thefloweringash @LnL7 @vcunat @FRidh