Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: loosen aiohttp version pin to unbreak build #104014

Merged
merged 1 commit into from Nov 17, 2020
Merged

home-assistant: loosen aiohttp version pin to unbreak build #104014

merged 1 commit into from Nov 17, 2020

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Nov 17, 2020

Motivation for this change

https://hydra.nixos.org/build/130630467

nixpkgs's aiohttp is currently 3.6.3, which is API compatible with 3.6.2
required by home-assistant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
home-assistant: loosen aiohttp version pin to unbreak build
f86a943 
nixpkgs's aiohttp is currently 3.6.3, which is API compatible with 3.6.2
required by home-assistant.
@mweinelt mweinelt merged commit 3bf2464 into NixOS:master Nov 17, 2020
@mweinelt
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delroth @mweinelt