Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svkbd: init at 0.3 #104147

Merged
merged 1 commit into from Apr 5, 2021
Merged

svkbd: init at 0.3 #104147

merged 1 commit into from Apr 5, 2021
+41 −0

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Nov 18, 2020

Motivation for this change

svkbd - Simple Virtual Keyboard.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir changed the title svkbd: init at 0.2.1 svkbd: init at 0.2.2 Dec 23, 2020
SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/tools/X11/svkbd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/svkbd/default.nix Outdated Show resolved Hide resolved
rmcgibbo
rmcgibbo approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on x86_64-linux and tested the svkbd-mobile-intl binary. Works fine.

@sikmir sikmir changed the title svkbd: init at 0.2.2 svkbd: init at 0.3 Mar 28, 2021
@SuperSandro2000 SuperSandro2000 merged commit ba334d8 into NixOS:master Apr 5, 2021
@sikmir sikmir deleted the svkbd branch April 5, 2021 22:36
@sternenseemann
Copy link
Member

Reverted in c8870b4.

svkbd was already added in 2fab566 and that package is even better arguably. Most significantly though having the svkbd attribute defined twice in all-packages.nix causes a failure at parse time.

Curiously, @SuperSandro2000 even merged both PRs.

@SuperSandro2000
Copy link
Member

I was just victim of stale ofborg checks. :P

Curiously, @SuperSandro2000 even merged both PRs.

I can't remember all PRs I have merged. There are just to many.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@rmcgibbo rmcgibbo rmcgibbo approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sikmir @sternenseemann @SuperSandro2000 @rmcgibbo