pythonPackages.psycopg2: document pypy incompatibility #104151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found the commit e69dd3b when it was disabled but it does not contain any explanation or links. When you look at the history around it https://github.com/nixos/nixpkgs/commits/e69dd3b9aa49/pkgs/top-level/python-packages.nix, it is probably a mass disable of broken packages. |
|
PyPy and extension modules don't work well together. Things have been changing, but as far as I know it still does not work very well or performant, hence the CFFI port. That commit is 5 years ago, things were quite different then. Especially regarding PyPy. |
lovesegfault
force-pushed
the
psycopg-pypy
branch
from
ffb3011
to
ce1c238
Compare
lovesegfault
changed the title
lovesegfault
force-pushed
the
psycopg-pypy
branch
from
ce1c238
to
c17499b
Compare
|
Alright, @FRidh, I've changed this to keep it disabled but to add a comment documenting the rationale with a ref to this dicussion :) |
jonringer
approved these changes
Nov 18, 2020
|
@FRidh pinging for merging |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I don't see any reason why it shouldn't work, and I can't find the original
rationale for it being disabled documented.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)