Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencc: 1.0.6 -> 1.1.1 #105312

Closed
wants to merge 1 commit into from
Closed

opencc: 1.0.6 -> 1.1.1 #105312

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/opencc/versions.

meta.description for opencc is: "A project for conversion between Traditional and Simplified Chinese"

meta.homepage for opencc is: "https://github.com/BYVoid/OpenCC"

meta.changelog for opencc is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
19543 total rebuild path(s)

6330 package rebuild(s)

6316 x86_64-linux rebuild(s)
5690 i686-linux rebuild(s)
2326 x86_64-darwin rebuild(s)
5211 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
AusweisApp2
DisnixWebService
OSCAR
PlistCpp
_1password-gui
abcm2ps
acgtk
acoustidFingerprinter
adapta-gtk-theme
adminer
adwaita-qt
aeon
agave
agda
agdaPackages.agda
agdaPackages.agda-categories
agdaPackages.agda-prelude
agdaPackages.cubical
agdaPackages.functional-linear-algebra
agdaPackages.generic
agdaPackages.iowa-stdlib
agdaPackages.standard-library
aj-snapshot
albert
aliza
almanah
amarok
amarok-kf5
ammonite
ammonite_2_12
ammonite_2_13
ams
android-file-transfer
animbar
anki
ankisyncd
antimicroX
antimony
ao
apache-airflow
apitrace
apmplanner2
apostrophe
appcsxcad
appleseed
aqemu
arcanist
ardour
ardour_5
arrow-cpp
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/la6j9s0aa3273gd3cv9b0kq07hd65zc5-opencc-1.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A opencc https://github.com/r-ryantm/nixpkgs/archive/b22b13c41a8a9e78261410a75a178b2d3f431fe3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/la6j9s0aa3273gd3cv9b0kq07hd65zc5-opencc-1.1.1
ls -la /nix/store/la6j9s0aa3273gd3cv9b0kq07hd65zc5-opencc-1.1.1/bin

Pre-merge build results

NixPkgs review skipped

Maintainer pings

cc @sifmelcara for testing.

@ofborg ofborg bot requested a review from sifmelcara November 29, 2020 03:15
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 29, 2020 •
edited

Result of nixpkgs-review pr 105312 run on x86_64-linux 1

3 packages failed to build:
  • brise
  • fcitx-engines.rime
  • librime
2 packages built:
  • goldendict
  • opencc

librime

/build/source/src/rime/gear/simplifier.cc: In member function 'bool rime::Opencc::ConvertWord(const string&, std::vector<std::__cxx11::basic_string<char> >*)':
/build/source/src/rime/gear/simplifier.cc:57:46: error: cannot convert 'std::__cxx11::basic_string<char>' to 'const char*' in initialization
   57 |       for (const char* value : entry->Values()) {
      |                                              ^
make[2]: *** [src/CMakeFiles/rime.dir/build.make:1213: src/CMakeFiles/rime.dir/rime/gear/simplifier.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:212: src/CMakeFiles/rime.dir/all] Error 2
make: *** [Makefile:160: all] Error 2

@sifmelcara
Copy link
Member

Looks like this new opencc version introduces API change. We probably want to update librime first.

The compilation error was addressed in rime/librime@beae5b1

@SuperSandro2000 SuperSandro2000 changed the base branch from staging to master January 20, 2021 22:59
@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 20, 2021 22:59
@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@siraben siraben closed this Jul 27, 2021
@r-ryantm r-ryantm deleted the auto-update/opencc branch July 28, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sifmelcara sifmelcara Awaiting requested review from sifmelcara

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @SuperSandro2000 @sifmelcara @siraben