Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnova: 0.12.3 -> 0.16 #105317

Merged
merged 1 commit into from Nov 29, 2020
Merged

libnova: 0.12.3 -> 0.16 #105317

merged 1 commit into from Nov 29, 2020

Conversation

hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Nov 29, 2020 •
edited

Motivation for this change

Update libnova to version 0.16 to receive bugfixes and new library features. Switch from x.x.x version numbers to x.x is necessary to move from defunct upstream tarball releases to git tags. Also added myself to the maintainer list since there are no maintainers listed for libnova.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lukegb
lukegb approved these changes Nov 29, 2020
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest that you run their "lntest" binary as part of the build (e.g.

  doCheck = true;
  checkPhase = "lntest/lntest";

...but it turns out that the tests are broken:

   Time 41.2 msecs
Test completed: 340 tests, 24 errors.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 29, 2020 •
edited

Result of nixpkgs-review pr 105317 run on x86_64-darwin 1

1 package failed to build:
  • xygrib
1 package built:
  • libnova

xygrib, already fails on master:

configuring
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/share/doc/XyGrib -DCMAKE_INSTALL_INFODIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/include -DCMAKE_INSTALL_SBINDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/l5707pca91sq99fd5fq4x84302zssyjj-cctools-binutils-darwin-949.0.1/bin/strip -DCMAKE_RANLIB=/nix/store/l5707pca91sq99fd5fq4x84302zssyjj-cctools-binutils-darwin-949.0.1/bin/ranlib -DCMAKE_AR=/nix/store/l5707pca91sq99fd5fq4x84302zssyjj-cctools-binutils-darwin-949.0.1/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/rmfv2gl1cyw33aj79fn0913xxcrmkl8v-xygrib-1.2.6.1 -DOPENJPEG_INCLUDE_DIR=/nix/store/4brnnpm8a29mcs8prvw0b2q85ibh0pwf-openjpeg-2.3.1-dev/include/openjpeg-2.3

-- The C compiler identification is Clang 7.1.0
-- The CXX compiler identification is Clang 7.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/b2qvdc4738nl7d8bn6d5gb6p9s34c78v-clang-wrapper-7.1.0/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/b2qvdc4738nl7d8bn6d5gb6p9s34c78v-clang-wrapper-7.1.0/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:56 (find_library):
  Could not find LIBNOVA_LIBRARY using the following names: libnova.a,
  libnova.so


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-xygrib-1.2.6.1.drv-0/source/build/CMakeFiles/CMakeOutput.log".

Edit: Fixed in #105338

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105317 run on x86_64-linux 1

5 packages built:
  • indilib
  • kstars
  • libnova
  • phd2
  • xygrib

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 29, 2020
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 merged commit 58b2984 into NixOS:master Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hjones2199 @SuperSandro2000 @lukegb