Add dir attribute to output argument if input specified dir. #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the input url specifies a dir component, this PR ensures that dir
specification is passed as an attribute on the argument provided to
the output function for that input:
inputs.foo.url = "https://github.com/group/proj?dir=sub/dir";
outputs = { self, foo }:
assert foo.dir == "sub/dir"; ...
This is useful for various library functions and other operations that
need to know if the input specified a subdirectory relative to the
fetch.
|
@edolstra This is ready for review and merge. |
|
I marked this as stale due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the input url specifies a dir component, this PR ensures that dir
specification is passed as an attribute on the argument provided to
the output function for that input:
This is useful for various library functions and other operations that
need to know if the input specified a subdirectory relative to the
fetch.