Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/go: convert to markdown #105025

Merged
merged 1 commit into from Nov 28, 2020
Merged

doc/go: convert to markdown #105025

merged 1 commit into from Nov 28, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 26, 2020 •
edited

Motivation for this change

#104966

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Nov 26, 2020
Closed
@Mic92
Copy link
Member Author

Mic92 commented Nov 26, 2020

Still waiting for nix-build to finish...

@Mic92 Mic92 requested a review from zowoq November 26, 2020 11:36
jtojnar
jtojnar requested changes Nov 26, 2020
View reviewed changes
doc/languages-frameworks/go.section.md Outdated Show resolved Hide resolved
@jtojnar jtojnar mentioned this pull request Nov 26, 2020
Merged
@Mic92 Mic92 force-pushed the go-doc branch 2 times, most recently from 19d0ce7 to d45e0db Compare November 28, 2020 06:29
@Mic92 Mic92 merged commit bc9313d into NixOS:master Nov 28, 2020
@Mic92 Mic92 deleted the go-doc branch November 28, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm left review comments

@jtojnar jtojnar jtojnar requested changes

@r-burns r-burns r-burns left review comments

@zowoq zowoq zowoq approved these changes

Assignees
No one assigned
Labels
6.topic: golang 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @ryantm @jtojnar @r-burns @zowoq