Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postfix: fix "cant find <mysql.h>" when building with "withMySQL = true" #105006

Merged
merged 1 commit into from Nov 26, 2020
Merged

postfix: fix "cant find <mysql.h>" when building with "withMySQL = true" #105006

merged 1 commit into from Nov 26, 2020

Conversation

ymarkus
Copy link
Contributor

@ymarkus ymarkus commented Nov 26, 2020 •
edited

Motivation for this change

Building postfix failed when using argument withMySQL = true with following error message: cant find <mysql.h>. This PR fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Thanks to @mizukota (in the NixOS matrix channel) for helping me figure this out.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105006 run on x86_64-linux 1

Builds with nix-build -E 'with import ./nixpkgs {}; postfix.override { withMySQL = true; }'.

@mweinelt mweinelt merged commit abd9ef1 into NixOS:master Nov 26, 2020
@mweinelt
Copy link
Member

Thanks!

@ymarkus ymarkus deleted the fix-postfixMySQL branch November 26, 2020 13:36
@ymarkus
Copy link
Contributor Author

ymarkus commented Nov 26, 2020

Great, thanks @mweinelt ! I'll submit a backporting PR.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 26, 2020
@ymarkus ymarkus mentioned this pull request Nov 26, 2020
Merged
10 tasks
@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 26, 2020
@mweinelt mweinelt added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ymarkus @SuperSandro2000 @mweinelt