Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rambox Pro 1.3.2 > 1.4.1 #104997

Merged
merged 2 commits into from Dec 28, 2020
Merged

Rambox Pro 1.3.2 > 1.4.1 #104997

merged 2 commits into from Dec 28, 2020

Conversation

kamushadenes
Copy link
Contributor

@kamushadenes kamushadenes commented Nov 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cawilliamson November 26, 2020 08:23
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104997 run on x86_64-linux 1

1 package marked as broken and skipped:
  • rambox-pro

@SuperSandro2000
Copy link
Member

Can you update the electron version this is using and test it?

@kamushadenes
Copy link
Contributor Author

Hello, thank you for reviewing.

I'm extremely new to Nix and NixOS (today is actually my very first day), so I'm having a hard time figuring things out.

Locally, I changed to use electron_7 and the app opens but stays at the loading screen forever.

Can you please point me to the general direction of some documentation on how to package applications in general, specially electron ones, so I can try and fix this?

Thanks!

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104997 run on x86_64-linux 1

1 package built:
  • rambox-pro

@SuperSandro2000 SuperSandro2000 merged commit 950c5e1 into NixOS:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cawilliamson cawilliamson Awaiting requested review from cawilliamson

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamushadenes @SuperSandro2000 @Janik-Haag