Fieldset NG: Support position:sticky content #26654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 26, 2020
LayoutBoxModelObject::UpdateStickyPositionConstraints() should allow an anonymous fieldset content box as a sticky container. Bug: 1128479, 1146925, 1149320 Change-Id: I12e37e347fcb4300891f524f0a2b7256d0d23d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562000 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#831727}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2562000
branch
from
761504e
to
45003b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutBoxModelObject::UpdateStickyPositionConstraints() should allow an
anonymous fieldset content box as a sticky container.
Bug: 1128479, 1146925, 1149320
Change-Id: I12e37e347fcb4300891f524f0a2b7256d0d23d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562000
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831727}