Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.hidapi: 0.10.0 -> 0.10.1 #105023

Merged
merged 1 commit into from Dec 3, 2020
Merged

python3Packages.hidapi: 0.10.0 -> 0.10.1 #105023

merged 1 commit into from Dec 3, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from np November 26, 2020 11:39
@prusnak prusnak changed the base branch from master to staging November 26, 2020 11:55
@ofborg ofborg bot requested a review from np November 26, 2020 12:18
@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 105023 1

12 packages failed to build:
  • python37Packages.btchip
  • python37Packages.ckcc-protocol
  • python37Packages.hidapi
  • python37Packages.hwi
  • python37Packages.keepkey
  • python37Packages.keepkey_agent
  • python37Packages.ledger_agent
  • python37Packages.ledgerblue
  • python37Packages.python-u2flib-host
  • python37Packages.trezor
  • python37Packages.trezor_agent
  • python39Packages.hwi
26 packages built:
  • cm-rgb
  • electron-cash
  • electrum
  • electrum-ltc
  • hwi (python38Packages.hwi)
  • keepkey_agent (python38Packages.keepkey_agent)
  • ledger_agent (python38Packages.ledger_agent)
  • plover.stable
  • python38Packages.btchip
  • python38Packages.ckcc-protocol
  • python38Packages.hidapi
  • python38Packages.keepkey
  • python38Packages.ledgerblue
  • python38Packages.python-u2flib-host
  • python38Packages.trezor
  • trezor_agent (python38Packages.trezor_agent)
  • python39Packages.btchip
  • python39Packages.ckcc-protocol
  • python39Packages.hidapi
  • python39Packages.keepkey
  • python39Packages.keepkey_agent
  • python39Packages.ledger_agent
  • python39Packages.ledgerblue
  • python39Packages.python-u2flib-host
  • python39Packages.trezor
  • python39Packages.trezor_agent

@prusnak
Copy link
Member Author

prusnak commented Nov 27, 2020

python37Packages.hidapi

The python37 broken packages seem spurious and not related to the PR itself which is just a very simple version update. I wonder if the Python 3.7 installation is broken in staging or what.

@prusnak
Copy link
Member Author

prusnak commented Nov 29, 2020

It seems that python3.7-pip is/was broken in staging and the build failure is indeed not related

@prusnak prusnak merged commit a46f2a0 into staging Dec 3, 2020
@prusnak prusnak deleted the python-hidapi branch December 3, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @RaghavSood