Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 292468330173
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a5da6e521578
Choose a head ref
  • 5 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 26, 2020

  1. kube3d: nixpkgs-fmt the file to fit contributing guidelines

    @06kellyjac
    06kellyjac committed Nov 26, 2020
    Copy the full SHA
    c36b5d5 View commit details
    Browse the repository at this point in the history

  2. kube3d: add a longDescription to provide detail and help searches 

    search.nixos.org was able to show me `deno` when searching for
"executable" which was in the longDescription
    @06kellyjac
    06kellyjac committed Nov 26, 2020
    Copy the full SHA
    7a03c0f View commit details
    Browse the repository at this point in the history

  3. kube3d: mention k3d in the short description 

    While I was able to find `deno` by searching for "executable" from it's
longDescription on search.nixos.org, I couldn't find it using `nix search`

`nix search` seems to only look at the short description so it's worth
including there too.
    @06kellyjac
    06kellyjac committed Nov 26, 2020
    Copy the full SHA
    168df5f View commit details
    Browse the repository at this point in the history

  4. kube3d: re-order the derivation and general cleanup 

    Moved k3sVersion to be a variable.
Converted buildFlagsArray to an array
Moved vendorSha256 closer to src
Moved doCheck between build and install related bits (like where the
phase happens)
Replaced stdenv.lib with lib
    @06kellyjac
    06kellyjac committed Nov 26, 2020
    Copy the full SHA
    cdfa9b0 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #99563 from 06kellyjac/kube3d_discoverability 

    kube3d: increase discoverability
    @kevincox
    kevincox committed Nov 26, 2020
    Copy the full SHA
    a5da6e5 View commit details
    Browse the repository at this point in the history