Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulumi: 2.10.2 -> 2.16.2 #105010

Closed
wants to merge 5 commits into from
Closed

pulumi: 2.10.2 -> 2.16.2 #105010

wants to merge 5 commits into from

Conversation

mudrii
Copy link
Contributor

@mudrii mudrii commented Nov 26, 2020 •
edited

Motivation for this change

Update pulumi to lates stable version and update all plugins to the latest version

Things done

Update and run the script with new pulumi version and plugins. Add new plugins to pulumi Azure, Kafka and TLS and add myself as maintener.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_merger

@SuperSandro2000
Copy link
Member

I fixed your checkboxes.

@SuperSandro2000
Copy link
Member

Can you please cherry-pick the commit from #105008 over into here? Thanks! This fixes the ofborg error.

@ofborg ofborg bot requested a review from jlesquembre November 26, 2020 12:30
@prusnak
Copy link
Member

prusnak commented Nov 26, 2020

#105008 has been merged.

Please drop the latter commit and keep only the first one.

@mudrii
Copy link
Contributor Author

mudrii commented Nov 27, 2020

#105008 has been merged.

Please drop the latter commit and keep only the first one.

commit reset to previouse change

@mudrii mudrii mentioned this pull request Nov 27, 2020
Closed
10 tasks
@mudrii
Copy link
Contributor Author

mudrii commented Nov 28, 2020

@jlesquembre @ghuntley @peterromfeldhk Please can you review PR

@jlesquembre
Copy link
Member

Result of nixpkgs-review pr 105010 1

1 package built:
  • pulumi-bin

@jlesquembre
Copy link
Member

I tested the executable, looks ok
@mudrii Can you please remove me from the maintainers list? I switched to terraform, I don't use pulumi any longer

@mudrii mudrii changed the title pulumi: 2.10.2 -> 2.14.0 pulumi: 2.10.2 -> 2.15.1 Dec 7, 2020
@mudrii
Copy link
Contributor Author

mudrii commented Dec 7, 2020

@cpcloud Please can you review and merge as I could see a few days back you updated pulumi to the latest version

@SuperSandro2000
Copy link
Member

@mudrii Please fix the merge conflict.

@cpcloud
Copy link
Contributor

cpcloud commented Dec 7, 2020

Is this PR meaningfully different from #105908?

@cpcloud
Copy link
Contributor

cpcloud commented Dec 7, 2020

Ah I see this is going to 2.15.1!

@SuperSandro2000
Copy link
Member

@mudrii Please fix the merge conflicts.

@mudrii mudrii changed the title pulumi: 2.10.2 -> 2.15.1 pulumi: 2.10.2 -> 2.15.4 Dec 9, 2020
@mudrii
Copy link
Contributor Author

mudrii commented Dec 9, 2020

Ah I see this is going to 2.15.1!

@cpcloud I updates to the latest pulumi fix 2.15.4 and update most of the plugins
post rebase conflicts should be fixed

cpcloud
cpcloud approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mudrii
Copy link
Contributor Author

mudrii commented Dec 11, 2020

can somebody please merge into the master?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105010 run on x86_64-linux 1

1 package built:
  • pulumi-bin

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105010 run on x86_64-darwin 1

1 package built:
  • pulumi-bin

@cpcloud
Copy link
Contributor

cpcloud commented Dec 29, 2020

This is already out of date now, we should merge it ASAP and get a PR up for the next version.

@mudrii
Copy link
Contributor Author

mudrii commented Dec 30, 2020

This is already out of date now, we should merge it ASAP and get a PR up for the next version.

I will update to a new version

@mudrii mudrii changed the title pulumi: 2.10.2 -> 2.15.4 pulumi: 2.10.2 -> 2.16.2 Dec 30, 2020
@ofborg ofborg bot requested a review from ghuntley December 30, 2020 10:58
@cpcloud
Copy link
Contributor

cpcloud commented Dec 30, 2020

Thanks @mudrii! @SuperSandro2000 Can we get this merged?

@mudrii
Copy link
Contributor Author

mudrii commented Jan 4, 2021

@SuperSandro2000 please can you review and merge?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 105010 run on x86_64-darwin 1

1 package built:
  • pulumi-bin

@cpcloud
Copy link
Contributor

cpcloud commented Jan 8, 2021

@mudrii this can be closed in light of #108814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

@jlesquembre jlesquembre jlesquembre approved these changes

@ghuntley ghuntley Awaiting requested review from ghuntley

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mudrii @SuperSandro2000 @prusnak @jlesquembre @cpcloud