Skip to content

gns3-server: relax aiohttp pin #104112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

gns3-server: relax aiohttp pin #104112

merged 1 commit into from
Nov 18, 2020
+3 −1

Conversation

mweinelt
Copy link
Member

Motivation for this change

While reviewing #104006 I noticed that the aiohttp pin was too strict.

ERROR: Could not find a version that satisfies the requirement aiohttp==3.6.2 (from gns3-server==2.2.16) (from versions: none)
ERROR: No matching distribution found for aiohttp==3.6.2 (from gns3-server==2.2.16)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mweinelt
gns3-server: relax aiohttp pin

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 226A2D41EF5378C9
Learn about vigilant mode
c05b2e7
@ofborg ofborg bot requested a review from primeos November 18, 2020 01:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 18, 2020
primeos
primeos approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Upstream's strict pinning can unfortunately be quite annoying...

@primeos primeos merged commit 023185b into NixOS:master Nov 18, 2020
@mweinelt mweinelt deleted the python/gns-server branch November 18, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @primeos