Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] crate2nix: init at 0.8.0 #104106

Merged
merged 1 commit into from Nov 23, 2020
Merged

[20.09] crate2nix: init at 0.8.0 #104106

merged 1 commit into from Nov 23, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Nov 17, 2020 •
edited

crate2nix is a tool that "generates nix build files for rust crates
using cargo".

(cherry picked from commit 011ecb8)

Motivation for this change

pijul uses nixos-20.09 in its flake, and we would like to use crate2nix from Nixpkgs -- thus, please merge the crate2nix init into the 20.09 branch ❤️

(There have been "init" backports in the past, so I'm hoping there is enough precedent for this to be non-controversial.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

EDIT: Backport of #104027.

@cole-h
crate2nix: init at 0.8.0
efadc52 
crate2nix is a tool that "generates nix build files for rust crates
using cargo".

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
(cherry picked from commit 011ecb8)
@cole-h cole-h requested a review from andir November 17, 2020 22:55
@andir andir self-assigned this Nov 17, 2020
andir
andir approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not a fan of doing any kind of changes for flakes while it isn't formally specified this is probably fine to be in 20.09 as I regulary need it myself :-)

@ofborg ofborg bot requested a review from andir November 17, 2020 23:37
@andir andir merged commit 899024b into NixOS:release-20.09 Nov 23, 2020
@cole-h cole-h deleted the crate2nix-20.09 branch November 23, 2020 21:55
@lboklin lboklin mentioned this pull request Dec 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

Assignees

@andir andir

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cole-h @andir @FRidh