Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.licenses: add Parity-7.0.0 license #104118

Merged
merged 1 commit into from Dec 18, 2020
Merged

lib.licenses: add Parity-7.0.0 license #104118

merged 1 commit into from Dec 18, 2020

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Nov 18, 2020 •
edited

Motivation for this change

Adds Parity-7.0.0 which was recently added to SPDX over at spdx/license-list-XML#949.

See https://paritylicense.com for more information.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabianhjr
Copy link
Member Author

@ghuntley

Before merging, I am unsure if this would be considered a free or non-free license.

@ghuntley
Copy link
Member

Gut feels: free, as in it doesn't restrict who can use it. It does require contribution back under certain circumstances such as AGPL. Worth dinging some other folks and getting their opinions as well.

@fabianhjr fabianhjr force-pushed the add-parity-license branch 2 times, most recently from e1e55c9 to 5008c70 Compare November 18, 2020 03:05
@vikanezrimaya
Copy link
Member

vikanezrimaya commented Nov 27, 2020 •
edited

Well, it's a "free for open source or personal use" license as it seems to me. If you share your work, you can do anything. If GPL is free with conditions (provide source code if you distribute or build upon), then this should probably be a free license too.

@doronbehar doronbehar merged commit 15edb39 into NixOS:master Dec 18, 2020
@fabianhjr fabianhjr deleted the add-parity-license branch December 25, 2020 06:48
@fabianhjr fabianhjr mentioned this pull request Nov 6, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghuntley ghuntley ghuntley approved these changes

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabianhjr @ghuntley @vikanezrimaya @doronbehar