Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.debugpy: 1.1.0 -> 1.2.0 #104117

Merged
merged 1 commit into from Nov 20, 2020
Merged

pythonPackages.debugpy: 1.1.0 -> 1.2.0 #104117

merged 1 commit into from Nov 20, 2020

Conversation

kira-bruneau
Copy link
Contributor

Motivation for this change

Upgrade to the latest version: https://github.com/microsoft/debugpy/releases/tag/v1.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    No binary files, only a Python library.
    Tested through dap-mode in Emacs.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

The tests are failing on python 3.7 and 3.8.

builder for '/nix/store/8jj9yychxvb64s5ks9cnklpm46kvwx6p-python3.8-debugpy-1.2.0.drv' failed with exit code 1; last 10 log lines:
  INTERNALERROR>     self.loop_once()
  INTERNALERROR>   File "/nix/store/ykcfjixirydid3gx9xfxrpjks6rnwx9n-python3.8-pytest-xdist-1.34.0/lib/python3.8/site-packages/xdist/dsession.py", line 135, in loop_once
  INTERNALERROR>     call(**kwargs)
  INTERNALERROR>   File "/nix/store/ykcfjixirydid3gx9xfxrpjks6rnwx9n-python3.8-pytest-xdist-1.34.0/lib/python3.8/site-packages/xdist/dsession.py", line 177, in worker_workerfinished
  INTERNALERROR>     assert not crashitem, (crashitem, node)
  INTERNALERROR> AssertionError: ('tests/debugpy/test_run.py::test_frame_eval[no-code-launch(externalTerminal)]', <WorkerController gw64>)
  INTERNALERROR> assert not 'tests/debugpy/test_run.py::test_frame_eval[no-code-launch(externalTerminal)]'
  
  ======== 1 failed, 915 passed, 8 skipped, 1 error in 127.60s (0:02:07) =========
  builder for '/nix/store/8jj9yychxvb64s5ks9cnklpm46kvwx6p-python3.8-debugpy-1.2.0.drv' failed with exit code 3

builder for '/nix/store/dvz94w6s9rar7rynaywcign4dswv6fdm-python3.7-debugpy-1.2.0.drv' failed with exit code 1; last 10 log lines:
  INTERNALERROR>     self.loop_once()
  INTERNALERROR>   File "/nix/store/lj27xm1l35kxiyyn08yfms61izkrdbbj-python3.7-pytest-xdist-1.34.0/lib/python3.7/site-packages/xdist/dsession.py", line 135, in loop_once
  INTERNALERROR>     call(**kwargs)
  INTERNALERROR>   File "/nix/store/lj27xm1l35kxiyyn08yfms61izkrdbbj-python3.7-pytest-xdist-1.34.0/lib/python3.7/site-packages/xdist/dsession.py", line 177, in worker_workerfinished
  INTERNALERROR>     assert not crashitem, (crashitem, node)
  INTERNALERROR> AssertionError: ('tests/debugpy/test_stop_on_entry.py::test_stop_on_entry[module-launch(externalTerminal)-]', <WorkerController gw64>)
  INTERNALERROR> assert not 'tests/debugpy/test_stop_on_entry.py::test_stop_on_entry[module-launch(externalTerminal)-]'
  
  ======== 1 failed, 935 passed, 8 skipped, 1 error in 132.45s (0:02:12) =========
  builder for '/nix/store/dvz94w6s9rar7rynaywcign4dswv6fdm-python3.7-debugpy-1.2.0.drv' failed with exit code 3

Result of nixpkgs-review pr 104117 1

2 packages failed to build:
  • python37Packages.debugpy
  • python38Packages.debugpy
1 package built:
  • python27Packages.debugpy

@kira-bruneau
Copy link
Contributor Author

@mweinelt Oh weird, it built successfully using the commit I based my changes on. Maybe there's a problem with one of the dependencies in the latest master?

@mweinelt
Copy link
Member

I checked out your branch, I didn't rebase it onto a newer master. Can you recheck?

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Nov 18, 2020 •
edited

Oh, right I pulled after testing, it's not working anymore 😕. I can force push the changes that were originally working, but then it will fail again once we merge to master.

Based on 2deeb58, the python37 & python38 packages sucesfully build:

  • /nix/store/5hkggci2rv3xbkjrsnban5j9apj379f3-python3.7-debugpy-1.2.0
  • /nix/store/0cs28avp6riwin82qxwi8c3vykm23kal-python3.8-debugpy-1.2.0

I will try bisecting the cause.

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Nov 18, 2020 •
edited

Yeah, apparently debugpy was broken just yesterday because a change in one of the dependencies: https://hydra.nixos.org/eval/1627728?filter=debugpy&compare=1627648&full=#tabs-still-fail

So it's not caused by the upgrade. I've created an issue here: #104125

@kira-bruneau kira-bruneau mentioned this pull request Nov 20, 2020
Closed
jonringer
jonringer approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104117 1

3 packages built:
  • python27Packages.debugpy
  • python37Packages.debugpy
  • python38Packages.debugpy

@jonringer jonringer merged commit 87e9b49 into NixOS:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kira-bruneau @mweinelt @jonringer