Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nmap: 7.80 -> 7.90" #105129

Merged
merged 1 commit into from Nov 27, 2020
Merged

Revert "nmap: 7.80 -> 7.90" #105129

merged 1 commit into from Nov 27, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 27, 2020

Motivation for this change

This reverts commit c426ccf.

License has changed in 7.90 and we should decide first how to proceed.
See #105119 for further context.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Revert "nmap: 7.80 -> 7.90"
fcbedf6 
This reverts commit c426ccf.

License has changed in 7.90 and we should decide first how to proceed.
See NixOS#105119 for further context.
@Ma27 Ma27 requested review from mweinelt and etu November 27, 2020 10:06
@SuperSandro2000
Copy link
Member

See #105119 (comment).

I would prefer if we add the new license and mark it unfree until this is clarified. If people want a free variant we could add nmap 7.80 as a separate package.

@gebner
Copy link
Member

gebner commented Nov 27, 2020

I would prefer if we add the new license and mark it unfree until this is clarified. If people want a free variant we could add nmap 7.80 as a separate package.

This would break all systems with nmap that don't have nixpkgs.config.allowUnfree enabled.

@etu etu merged commit 144a972 into NixOS:master Nov 27, 2020
@Ma27 Ma27 deleted the nmap-780 branch November 27, 2020 10:49
This was referenced Jan 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@etu etu Awaiting requested review from etu

@fpletz fpletz Awaiting requested review from fpletz

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @SuperSandro2000 @gebner @etu