Result of nixpkgs-review pr 105130 1

Result of nixpkgs-review pr 105130 run on x86_64-linux 1

ccing all maintainers: @thedavidmeister @nyanloutre @RaghavSood @Th0rgal

Honest question - what's the point of maintaining this in nixpkgs? AppImage should work just fine via appimage-run and with the release cycle of ~2 weeks this will get obsoleted by the time it is merged to master, not to mention reaching the unstable channel.

To be honest I didn't know appimage-run. However, ledger-live-desktop is a rather sensitive piece of software and with all the phishing attempts going on, I think it's more important to be sure to have an official build than to have the latest version.

Could you please squash the formatting and update commits into a single one, and split adding yourself to the maintainer list into a separate commit so that we can safely revert the update without kicking you off the list if necessary?

Not that I believe we'll need to revert, just a safety practice

LGTM apart from that

Agreed that there is some security value in having ledger-live as a maintained package - the r-ryan or one of us usually picks it up within a few hours of a new release, but I could set up some automation for it if we start slipping.

Could you please squash the formatting and update commits into a single one, and split adding yourself to the maintainer list into a separate commit so that we can safely revert the update without kicking you off the list if necessary?

Not that I believe we'll need to revert, just a safety practice

LGTM apart from that

Agreed that there is some security value in having ledger-live as a maintained package - the r-ryan or one of us usually picks it up within a few hours of a new release, but I could set up some automation for it if we start slipping.

Here we go!

ccing all maintainers: @thedavidmeister @nyanloutre @RaghavSood @Th0rgal

Honest question - what's the point of maintaining this in nixpkgs? AppImage should work just fine via appimage-run and with the release cycle of ~2 weeks this will get obsoleted by the time it is merged to master, not to mention reaching the unstable channel.

I run my system on unstable and it's much more convenient to get software updates from the nix store than to manually download an AppImage and store it at a random location.