Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdm: removed #105136

Merged
merged 1 commit into from Dec 11, 2020
Merged

tdm: removed #105136

merged 1 commit into from Dec 11, 2020

Conversation

cizra
Copy link
Contributor

@cizra cizra commented Nov 27, 2020 •
edited

Motivation for this change

I can't get sound to work in The Dark Mod - OpenAL is not detecting any hardware.
As a workaround, it's possible to use a precompiled version with steam-run.
Fixes #98936

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Nov 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove it from pkgs/top-level/all-packages.nix and add an alias that throws that it got removed.

SuperSandro2000
SuperSandro2000 requested changes Nov 28, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Also please resolve the merge conflict.

SuperSandro2000
SuperSandro2000 approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine now.

@symphorien symphorien merged commit 9101c02 into NixOS:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tdm: The Dark Mod fails to start on NixOS 20.09
3 participants
@cizra @SuperSandro2000 @symphorien