New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smaller improvements to the README #652
Conversation
2d3a7b8
to
984cb02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit picks, some weird english formulation. And a request that I don't think will be handled.
Otherwise good idea.
Co-authored-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
In addition to the review, I will formally add that I don't like embracing a third-party service as part of the official presentation and documentation of the project. I'm talking about While yes, they allow self-hosting, adding it that way to the README and the project adds tacit approval from the organization to that service. |
Co-authored-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
Co-authored-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
Co-authored-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
Co-authored-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
Co-authored-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
Co-authored-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
I've address all the comments and suggestions.
Personally I don't think having a GitPod link in readme adds any approval from the organization. I would like more contributions and if that means we will add more configuration for services that help contributors of But there is a big difference when adding this links and promoting this tools and services on the nixos.org or other subdomains. We should use all the help internet can provide in order to attract more contributions to |
I'm not in favor of adding a dependency on yet another proprietary service, especially when it should be unnecessary. Building the homepage should require nothing more than running
I think that's a bit naive. From the Gitpod homepage: "Describe your dev environments as code". That's exactly what Nix purports to do, so the fact that we're relying on Gitpod undercuts the argument for using Nix. |
If this would be the case then I wouldn't be trying to convince you to add this button.
I don't think relying on GitPod undercuts the argument for using Nix. Then we could use the same argument for Docker or even AWS. Nix works alongside Docker and AWS and improves the experience. This is the same for Gitpod. Just to move further I will remove this link and configuration, but I hope to discuss this at the next marketing meeting. Eg. why do we provide links to AWS and not to other services. Just to define what are the guidelines and what are the policies. |
and some smaller improvements to the README
This change is