Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Appcpm: init at 0.994 #105137

Merged
merged 1 commit into from Nov 27, 2020
Merged

perlPackages.Appcpm: init at 0.994 #105137

merged 1 commit into from Nov 27, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Nov 27, 2020

Motivation for this change

https://metacpan.org/release/App-cpm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner November 27, 2020 12:08
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105137 run on x86_64-linux 1

2 packages built:
  • perl530Packages.Appcpm
  • perl532Packages.Appcpm

stigtsp
stigtsp approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Tested OK on linux x86 and darwin x86

Result of nixpkgs-review pr 105137 1

2 packages built:
  • perl530Packages.Appcpm
  • perl532Packages.Appcpm

@stigtsp stigtsp merged commit dc2c340 into NixOS:master Nov 27, 2020
@zakame
Copy link
Member Author

zakame commented Nov 27, 2020

Thanks again everyone! 🎉

@zakame zakame deleted the contrib/perl-App-cpm branch November 27, 2020 13:10
@stigtsp
Copy link
Member

stigtsp commented Nov 27, 2020

Thanks again everyone! tada

Thx for the contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakame @SuperSandro2000 @stigtsp