Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains: updates #105135

Merged
merged 1 commit into from Nov 27, 2020
Merged

jetbrains: updates #105135

merged 1 commit into from Nov 27, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 27, 2020

Motivation for this change

Mainly the new idea-community for me

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Verified idea-community can compile and test a Scala project

@raboof raboof requested a review from edwtjo as a code owner November 27, 2020 11:45
@raboof
Copy link
Member Author

raboof commented Nov 27, 2020

Result of nixpkgs-review pr 105135 1

9 packages built:
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.idea-community
  • jetbrains.idea-ultimate
  • jetbrains.phpstorm
  • jetbrains.pycharm-community
  • jetbrains.pycharm-professional
  • jetbrains.ruby-mine
  • jetbrains.webstorm

@Ma27 Ma27 merged commit b124d00 into NixOS:master Nov 27, 2020
@Ma27
Copy link
Member

Ma27 commented Nov 27, 2020

@raboof should we also backport this? (2020.2 is also on 20.09 and this is "only" a patch-level update AFAICS).

@raboof
Copy link
Member Author

raboof commented Nov 30, 2020

@raboof should we also backport this? (2020.2 is also on 20.09 and this is "only" a patch-level update AFAICS).

I don't know what the policy around this is - since it's 'only' a patch-level update perhaps it's not important to backport? Personally I'm happy with this update in unstable :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @Ma27