Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.snowflake-connector-python: Fix boto3 replace #105128

Merged
merged 2 commits into from Nov 27, 2020
Merged

python3Packages.snowflake-connector-python: Fix boto3 replace #105128

merged 2 commits into from Nov 27, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#100977 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 105128 run on x86_64-linux 1

4 packages built:
  • python37Packages.snowflake-connector-python
  • python37Packages.snowflake-sqlalchemy
  • python38Packages.snowflake-connector-python
  • python38Packages.snowflake-sqlalchemy

jonringer
jonringer approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 105128 1

4 packages built:
  • python37Packages.snowflake-connector-python
  • python37Packages.snowflake-sqlalchemy
  • python38Packages.snowflake-connector-python
  • python38Packages.snowflake-sqlalchemy

@jonringer jonringer merged commit 08c74a2 into NixOS:master Nov 27, 2020
@SuperSandro2000 SuperSandro2000 deleted the snoflake branch November 27, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @jonringer