Create compositor animation for background-color #26610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 23, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2549530
branch
4 times, most recently
from
eaba239
to
af67881
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2549530
branch
4 times, most recently
from
1afabf6
to
aedf142
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2549530
branch
3 times, most recently
from
8cf9f35
to
035a151
Compare
This CL is the first step of the background-color animation using off-thread paint worklet infrastructure. The design doc is here: https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit In particular, this CL just make sure that we are able to create a compositor animation for background-color. Then the compositor thread ticks the animation and dispatches the paint job to the worker thread to paint. In the actual paint, we do hard code the result, which means there is no interpolation implementation at this moment. We will implement the interpolation logic in a coming CL. Bug: 1139008, 1148369 Change-Id: I9d2aba2106f38f89bce0e97df29fa0d4f30b2c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549530 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834886}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2549530
branch
from
035a151
to
6f25a06
Compare
|
Checks passes on TC but status didn't make it to Github. Retrying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL is the first step of the background-color animation using
off-thread paint worklet infrastructure. The design doc is here:
https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit
In particular, this CL just make sure that we are able to create a
compositor animation for background-color. Then the compositor
thread ticks the animation and dispatches the paint job to
the worker thread to paint.
In the actual paint, we do hard code the result, which means
there is no interpolation implementation at this moment. We
will implement the interpolation logic in a coming CL.
Bug: 1139008, 1148369
Change-Id: I9d2aba2106f38f89bce0e97df29fa0d4f30b2c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549530
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834886}