Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.AnyEventAIO: init at 1.1 #104663

Merged
merged 2 commits into from Nov 23, 2020
Merged

perlPackages.AnyEventAIO: init at 1.1 #104663

merged 2 commits into from Nov 23, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 23, 2020

Motivation for this change

Adds the AnyEvent::AIO Perl module.

dependencies:
perlPackages.IOAIO: init at 4.72

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested OK on linux x64 and darwin x64

Result of nixpkgs-review 1

4 packages built:
  • perl530Packages.AnyEventAIO
  • perl530Packages.IOAIO
  • perl532Packages.AnyEventAIO
  • perl532Packages.IOAIO

@stigtsp
Copy link
Member Author

stigtsp commented Nov 23, 2020

Cc: @zakame

@stigtsp stigtsp mentioned this pull request Nov 23, 2020
Closed
@stigtsp
Copy link
Member Author

stigtsp commented Nov 23, 2020

Cc: @Vonfry

@stigtsp
Copy link
Member Author

stigtsp commented Nov 23, 2020

@GrahamcOfBorg build perlPackages.AnyEventAIO
@GrahamcOfBorg build perldevelPackages.AnyEventAIO

@zakame
Copy link
Member

zakame commented Nov 23, 2020

Nice, for Perl::LanguageServer I presume? I think I had an expression for this prepared before...

@stigtsp
Copy link
Member Author

stigtsp commented Nov 23, 2020 •
edited

Nice, for Perl::LanguageServer I presume? I think I had an expression for this prepared before...

Ah yes, it seems to be what triggered #103603. Would be great with a PR for Perl::LanguageServer. :)

@Vonfry
Copy link
Member

Vonfry commented Nov 23, 2020

Thanks for this pr.

@zakame , would you like to wrap Perl::LanguageServer ?

@SuperSandro2000 SuperSandro2000 removed their request for review November 23, 2020 13:08
@stigtsp stigtsp merged commit b465f8e into NixOS:master Nov 23, 2020
@zakame
Copy link
Member

zakame commented Nov 26, 2020

@Vonfry yeah, let me update my stuff here and I'll post a PR soon

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104663 run on x86_64-linux 1

4 packages built:
  • perl530Packages.AnyEventAIO
  • perl530Packages.IOAIO
  • perl532Packages.AnyEventAIO
  • perl532Packages.IOAIO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stigtsp @zakame @Vonfry @SuperSandro2000