Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate cached FilterData on SVG resource containers as well #26613

Merged
merged 1 commit into from Nov 23, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 23, 2020

We create the effect nodes for resource containers as well - which can
instantiate FilterData - so we need to invalidate it when the filter
content changes too.

Bug: 1151610
Change-Id: Ic4ef00b1ee7b0e44cd9237bca5683996e787e91c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554544
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#830252}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

We create the effect nodes for resource containers as well - which can
instantiate FilterData - so we need to invalidate it when the filter
content changes too.

Bug: 1151610
Change-Id: Ic4ef00b1ee7b0e44cd9237bca5683996e787e91c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554544
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#830252}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants