Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libslirp: fix CVE-2020-29129 #105157

Merged
merged 2 commits into from Nov 30, 2020
Merged

libslirp: fix CVE-2020-29129 #105157

merged 2 commits into from Nov 30, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

Fixes out-of-bounds access while processing ARP/NCSI packets.

Fixes: CVE-2020-29129

https://lists.freedesktop.org/archives/slirp/2020-November/000115.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 27, 2020
stigtsp
stigtsp reviewed Nov 27, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 105157 run on x86_64-linux 1

4 packages built:
  • buildah
  • libslirp
  • podman
  • slirp4netns

@mweinelt
Copy link
Member Author

FWIW: QEMU will still be vulnerable, because we are currently using a vendored libslirp version.

#101608 was going to change that, but didn't happen. Can I pick up those changes? @zowoq

zowoq
zowoq reviewed Nov 27, 2020
View reviewed changes
pkgs/development/libraries/libslirp/CVE-2020-29129.patch Outdated
switch (ar_op) {
case ARPOP_REQUEST:
--
2.28.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch file can be removed.

@mweinelt mweinelt force-pushed the libslirp branch 2 times, most recently from 76a4583 to a368f6f Compare November 28, 2020 01:45
@mweinelt
libslirp: fix CVE-2020-29129, CVE-2020-29130
984271b 
Fixes out-of-bounds access while processing ARP/NCSI packets.

Fixes: CVE-2020-29129, CVE-2020-29130
@mweinelt
qemu: fix CVE-2020-29129, CVE-2020-29130 in vendored libslirp
bd3ce46 
Fixes out-of-bounds access in libslirp while processing ARP/NCSI packets.

Fixes: CVE-2020-29129, CVE-2020-29130
@mweinelt
Copy link
Member Author

Patched the vendored libslirp in QEMU as well.

@ofborg ofborg bot requested a review from edolstra November 28, 2020 01:58
@mweinelt mweinelt merged commit 3200eae into NixOS:master Nov 30, 2020
@mweinelt mweinelt deleted the libslirp branch November 30, 2020 14:56
@mweinelt
Copy link
Member Author

Ported to 20.09 in b7fd0c0 aa8ba40

@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp left review comments

@zowoq zowoq zowoq left review comments

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @stigtsp @zowoq