poweralertd: init at 0.1.0 #105165
Merged
poweralertd: init at 0.1.0 #105165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibautMarty
force-pushed
the
poweralertd
branch
from
70f7e33
to
54c684f
Compare
|
@ofborg eval |
ThibautMarty
force-pushed
the
poweralertd
branch
from
54c684f
to
846ede0
Compare
rmcgibbo
suggested changes
Mar 16, 2021
There was a problem hiding this comment.
Doesn't build, probably because of #115397
these 3 derivations will be built:
/nix/store/w2rl7k1iq8cxnsn1i8nkvfqsnkvh0vx1-0.1.0.tar.gz.drv
/nix/store/bddr62gq5wnyqzn8qr9zfvi9bfgjvnv8-poweralertd-0.1.0.drv
/nix/store/fcnm0xxp4yjr928y41c7hbxpw63b5854-review-shell.drv
building '/nix/store/w2rl7k1iq8cxnsn1i8nkvfqsnkvh0vx1-0.1.0.tar.gz.drv'...
trying https://git.sr.ht/~kennylevinsen/poweralertd/archive/0.1.0.tar.gz
trying https://git.sr.ht/~kennylevinsen/poweralertd/archive/0.1.0.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
Dload Upload Total Spent Left Speed
100 39484 0 39484 0 0 264k 0 --:--:-- --:--:-- --:--:-- 264k
100 39484 0 39484 0 0 264k 0 --:--:-- --:--:-- --:--:-- 264k
hash mismatch in fixed-output derivation '/nix/store/dalkdaz6rwi9an09q12s0vbv0wijz30l-0.1.0.tar.gz':
wanted: sha256:11b0lgrp7kyysvc8gh8w37ydig74j2bg0y885ir73w3pym6sy65a
got: sha256:16navzl54b42qasvi3ygqgikih3rxh9af0rakwpi7dz6xw646vn2
cannot build derivation '/nix/store/bddr62gq5wnyqzn8qr9zfvi9bfgjvnv8-poweralertd-0.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fcnm0xxp4yjr928y41c7hbxpw63b5854-review-shell.drv': 1 dependencies couldn't be built
846ede0
to
00f04cf
Compare
|
I fixed the hash and used For the record, note that the package does not cross-compile because of (at least) a broken diff --git c/meson.build i/meson.build
index 6a7cb74..d2075aa 100644
--- c/meson.build
+++ i/meson.build
@@ -49,10 +49,11 @@ executable(
install: true,
)
-scdoc = dependency('scdoc', required: get_option('man-pages'), version: '>= 1.9.7')
+scdoc = dependency('scdoc', required: get_option('man-pages'), version: '>= 1.9.7', native: true)
if scdoc.found()
- sh = find_program('sh')
+ scdoc_prog = find_program(scdoc.get_pkgconfig_variable('scdoc'), native: true)
+ sh = find_program('sh', native: true)
man_pages = ['poweralertd.1.scd']
@@ -68,7 +69,7 @@ if scdoc.found()
input: src,
output: output,
command: [
- sh, '-c', '@0@ < @INPUT@ > @1@'.format(scdoc.get_pkgconfig_variable('scdoc'), output)
+ sh, '-c', '@0@ < @INPUT@ > @1@'.format(scdoc_prog.path(), output)
],
install: true,
install_dir: '@0@/man@1@'.format(mandir, section) |
|
Note that |
ThibautMarty
force-pushed
the
poweralertd
branch
from
00f04cf
to
df63ee8
Compare
|
I just force-pushed some modifications which make cross-compilation work (with the given patch, #117914 is needed too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
poweralertd package from https://git.sr.ht/~kennylevinsen/poweralertd.
Things done
The package ships with a systemd user file which works, although I patched the
meson.buildfile to put the service file in the derivation's output instead or trying to put it in/nix/store/…-systemd-246.6/lib/systemd/user.Note: depends on #104920 for the maintainer entry.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)