Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.browsermob-proxy: drop insecure python-cryptography tr… #105141

Merged
merged 1 commit into from Nov 27, 2020
Merged

pythonPackages.browsermob-proxy: drop insecure python-cryptography tr… #105141

merged 1 commit into from Nov 27, 2020

Conversation

7c6f434c
Copy link
Member

…ansitive dependency; only used for Marionette anyway

Motivation for this change

python2Packages.cryptography is marked insecure

will self-merge once tests pass

Tested marionette-harness working

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
pythonPackages.browsermob-proxy: drop insecure python-cryptography tr…
ac3f600 
…ansitive dependency; only used for Marionette anyway
@7c6f434c 7c6f434c merged commit bfa0cc6 into NixOS:master Nov 27, 2020
@jonringer
Copy link
Contributor

this should have been scoped to only python2

@7c6f434c
Copy link
Member Author

Maybe, but for any non-Marionette use I would recommend to use browsermob-proxy2, not browsermob-proxy0 anyway.

@SuperSandro2000
Copy link
Member 

Result of `nixpkgs-review pr 105141` run on x86_64-darwin [1](https://github.com/Mic92/nixpkgs-review)
<details>
  <summary>2 packages built:</summary>
  <ul>
    <li>python27Packages.browsermob-proxy</li>
    <li>python27Packages.marionette-harness</li>
  </ul>
</details>

@7c6f434c
Copy link
Member Author

Hm, should I explicitly move browsermob-proxy (0) under marionette-harness directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@7c6f434c @jonringer @SuperSandro2000