Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: Add an updateScript #105166

Merged
merged 1 commit into from Dec 1, 2020
Merged

plex: Add an updateScript #105166

merged 1 commit into from Dec 1, 2020

Conversation

SamirHafez
Copy link
Contributor

Motivation for this change

Plex has a JSON API endpoint with download links and checksums for the media server. These checksums are sha1 so it's convenient to change the current sha256 to match that sha1

Things done
  • Use the Plex JSON API to fetch checksums
  • Switch current sha256 checksums with sha1 versions
  • Add an updateScript that sets version and checksums based on this JSON API

@Ma27 Ma27 requested a review from elseym November 30, 2020 10:32
@elseym
Copy link
Member

elseym commented Nov 30, 2020

thanks for the updater script!

do you think it's possible to keep the sha256 hashes and modify the script to use the output of nix-prefetch-url as new hash instead?

Mic92
Mic92 reviewed Nov 30, 2020
View reviewed changes
pkgs/servers/plex/raw.nix Outdated Show resolved Hide resolved
@SamirHafez SamirHafez force-pushed the plex-updateScript branch 2 times, most recently from c98297b to 2f3b0ce Compare November 30, 2020 14:38
@SamirHafez
Copy link
Contributor Author

@Mic92 @elseym Moved back to sha256 and used nix-prefetch-url as suggested in order to get the hash. Please have another look 🙇

elseym
elseym approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@elseym elseym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well via nix-shell maintainers/scripts/update.nix --argstr package plexRaw

@elseym elseym merged commit eb079d2 into NixOS:master Dec 1, 2020
@SamirHafez SamirHafez deleted the plex-updateScript branch December 1, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elseym elseym elseym approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@pjones pjones Awaiting requested review from pjones

@Forkk Forkk Awaiting requested review from Forkk

@colemickens colemickens Awaiting requested review from colemickens

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SamirHafez @elseym @Mic92