Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out the OrbitAnalyser::Analysis to OrbitAnalysis conversion #2798

Merged
merged 6 commits into from
Nov 27, 2020

Conversation

eggrobin
Copy link
Member

We will need to do it for flight plan analyses as well.

@pleroy
Copy link
Member

pleroy commented Nov 27, 2020

retest this please

@@ -533,6 +533,83 @@ Interval ToInterval(geometry::Interval<T> const& interval) {
interval.max / quantities::si::Unit<T>};
}

inline void FillOrbitAnalysis(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, New.

int const ground_track_revolution,
not_null<OrbitAnalysis*> analysis) {
int const ground_track_revolution) {
auto analysis = new OrbitAnalysis{};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto* const

@pleroy pleroy added the LGTM label Nov 27, 2020
@eggrobin eggrobin merged commit b8d380d into mockingbirdnest:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants