Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racket: Update source hashes #105147

Merged
merged 1 commit into from Nov 27, 2020
Merged

racket: Update source hashes #105147

merged 1 commit into from Nov 27, 2020

Conversation

meithecatte
Copy link
Contributor

Upstream has replaced the tarballs in place to fix racket/racket#3499.

I have verified that the new binaries can install packages properly, unlike
the old ones.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • nixpkgs-review uses too much RAM, built racket and racket-minimal manually.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@meithecatte
racket: Update source hashes
9c01258 
Upstream has replaced the tarballs in place to fix racket/racket#3499.
@SuperSandro2000
Copy link
Member

It would make things easier if people would just release a new minor version...

@meithecatte
Copy link
Contributor Author

meithecatte commented Nov 27, 2020 via email

mohe2015
mohe2015 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@mohe2015 mohe2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work properly.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105147 run on x86_64-linux 1

3 packages built:
  • fluxus
  • racket
  • racket-minimal

@mohe2015
Copy link
Contributor

mohe2015 commented Nov 27, 2020 •
edited

offtopic question: Is there a way to provide libportaudio.so and ffmpeg to the video racket package without recompiling racket or something like that?
Edit: this hack worked:

portaudio=$(nix build --json nixpkgs#portaudio | jq -r '.[0].outputs.out')/lib
ffmpeg=$(nix build --json nixpkgs#ffmpeg-full | jq -r '.[0].outputs.out')/lib

LD_LIBRARY_PATH=$portaudio:$ffmpeg drracket

@SuperSandro2000 SuperSandro2000 merged commit 722ac69 into NixOS:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohe2015 mohe2015 mohe2015 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After updating to Racket 7.9 Raco is unable to install packages
3 participants
@meithecatte @SuperSandro2000 @mohe2015