Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.wxPython_4_0: build on darwin #105159

Closed
wants to merge 2 commits into from
Closed

python3Packages.wxPython_4_0: build on darwin #105159

wants to merge 2 commits into from

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#97101

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Nov 27, 2020
@ofborg ofborg bot requested review from LnL7 and lopsided98 November 27, 2020 16:46
@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 27, 2020 17:08
@SuperSandro2000
Copy link
Member Author

@fricklerhandwerk Well, I could not get it to work.

../../../sip/cpp/sip_webkitwxWebKitCtrl.cpp:50:35: error: unknown class name 'wxWebKitCtrl'; did you mean 'sipwxWebKitCtrl'?
class sipwxWebKitCtrl : public  ::wxWebKitCtrl

and 20 more of such errors.

I tried differnet versions and compile flags and fetching from GitHub but everything failed with similar errors but at different positions.

@LnL7 Do you have any idea?

@fricklerhandwerk
Copy link
Contributor

You have to add WebKit at pkgs/top-level/all-packages.nix:761
Please check my old PR.

@SuperSandro2000
Copy link
Member Author

You have to add WebKit at pkgs/top-level/all-packages.nix:761
Please check my old PR.

Forgot to push that. Still fails with the above error.

@fricklerhandwerk
Copy link
Contributor

Now I'm confused, because something you did with force-pushing made this change, which should fix the wxmac build disappear. I suggest not force-pushing at all, if we work on small changes like this one and the repository allows for squash merging.

@fricklerhandwerk
Copy link
Contributor

@SuperSandro2000 Are you still available for finishing this? I'm quite disappointed now, because I was ready to complete the original PR back then, but handed it over because you asked, and now this one is stuck. :(

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 Are you still available for finishing this? I'm quite disappointed now, because I was ready to complete the original PR back then, but handed it over because you asked, and now this one is stuck. :(

Sorry about this. I thought this would be a very quick fix and I would be able to finish it in an evening but the building time is way to high to comfortable debug this. I'll reopen your PR.

@SuperSandro2000 SuperSandro2000 deleted the wxpython-4.0-darwin branch January 23, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@lopsided98 lopsided98 Awaiting requested review from lopsided98

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @fricklerhandwerk